[code-reflection] RFR: Add support for other onnx providers (CoreML) [v2]
Ana Maria Mihalceanu
duke at openjdk.org
Mon Oct 20 14:36:43 UTC 2025
On Fri, 17 Oct 2025 13:25:07 GMT, Adam Sotona <asotona at openjdk.org> wrote:
>> Ana Maria Mihalceanu has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update full name
>
> cr-examples/onnx/opgen/setup.sh line 1:
>
>> (failed to retrieve contents of file, check the PR for context)
> Files related to (re)generation of the library could be better stored under opgen folder/project.
I moved the files to `opgen` and changed the instructions accordingly.
> cr-examples/onnx/src/main/java/oracle/code/onnx/OnnxRuntime.java line 244:
>
>> 242: }
>> 243:
>> 244: public static <T> T executeWithOptions(Arena arena, MethodHandles.Lookup l, OnnxFunction<T> codeLambda, SessionOptions options) {
>
> I would recommend to make this method as an override of execute.
> Original execute duplicates the code, so it can delegate with no options instead.
Adam, can you please check the refactoring done for execute?
-------------
PR Review Comment: https://git.openjdk.org/babylon/pull/618#discussion_r2445195367
PR Review Comment: https://git.openjdk.org/babylon/pull/618#discussion_r2445204160
More information about the babylon-dev
mailing list