[code-reflection] RFR: Add support for other onnx providers (CoreML) [v2]

Adam Sotona asotona at openjdk.org
Mon Oct 20 15:37:40 UTC 2025


On Mon, 20 Oct 2025 14:33:03 GMT, Ana Maria Mihalceanu <duke at openjdk.org> wrote:

>> cr-examples/onnx/src/main/java/oracle/code/onnx/OnnxRuntime.java line 244:
>> 
>>> 242:     }
>>> 243: 
>>> 244:     public static <T> T executeWithOptions(Arena arena, MethodHandles.Lookup l, OnnxFunction<T> codeLambda, SessionOptions options) {
>> 
>> I would recommend to make this method as an override of execute.
>> Original execute duplicates the code, so it can delegate with no options instead.
>
> Adam, can you please check the refactoring done for execute?

Yes, it looks good now.

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/618#discussion_r2445375325


More information about the babylon-dev mailing list