[code-reflection] RFR: Fix SSABraun bug and add SSA tests [v2]

[Ruby Chen]

On Wed, 10 Sep 2025 19:21:23 GMT, Hannes Greule <hgreule at openjdk.org> wrote:

>> Ruby Chen has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - Replace deleted phi after recursive call
>>  - Merge branch 'openjdk:code-reflection' into inline
>>  - Merge branch 'openjdk:code-reflection' into inline
>>  - Merge branch 'openjdk:code-reflection' into inline
>>  - Fix SSABraun bug and add SSA tests
>
> src/jdk.incubator.code/share/classes/jdk/incubator/code/analysis/SSABraun.java line 200:
> 
>> 198:         for (Phi user : phiUsers) {
>> 199:             Val res = tryRemoveTrivialPhi(user);
>> 200:             if (same.equals(user)) {
> 
> For consistency, could you also use `==` here?

Actually, I'm looking into that right now! I'm not sure if that might cause some issues if there are two var stores that use the same operand - doing some testing atm

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/542#discussion_r2337717675