review request for 6787106

[John Rose]

+1 for BSD support,  +1 for fewer casts,  +1 for 32/64 source  
convergence!

Two minor comments:

Don't replace a name by a naked constant; use a cast in  
templateTable_x86_32:
-          __ movl(Address(rdx, 0), NULL_WORD);
+          __ movl(Address(rdx, 0), 0);
++         __ movl(Address(rdx, 0), (int32_t)NULL_WORD);


It would be better to put parens around the macro definition:
-    #define NULL_WORD  0
+    #define NULL_WORD  (intptr_t)0
++   #define NULL_WORD  ((intptr_t)0)

Reviewed.

-- John

On Dec 19, 2008, at 11:42 AM, Xiaobin Lu wrote:

> http://webrev.invokedynamic.info/xiaobin.lu/6787106/webrev/
>
> CR 6787106:  Hotspot 32 bit build fails on platforms having  
> different definitions for intptr_t & int32_t
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/bsd-port-dev/attachments/20081219/75f3759a/attachment.html