[PATCH] Fix building of j2se with OTHER_CXXFLAGS set in environment

[Diego 'Flameeyes' Pettenò]

When OTHER_CXXFLAGS is set in environment, as seems to be suggested in
the makefiles to set extra CFLAGS/CXXFLAGS, the build fails with this
error:

     [exec] /var/tmp/portag/dev-java/openjdk-1.7.0.0_alpha12/work/openjdk/control/build/linux-amd64/tmp/sun/com.sun.java.util.jar.pack/unpack-cmd/obj64
/unpack.o: In function `unpacker::redirect_stdio()':
     [exec] /var/tmp/portag/dev-java/openjdk-1.7.0.0_alpha12/work/openjdk/j2se/make/com/sun/java/pack/../../../../../src/share/native/com/sun/java/util
/jar/pack/unpack.cpp:4665: warning: the use of `tempnam' is dangerous,
better use
`mkstemp' [exec] /var/tmp/portag/dev-java/openjdk-1.7.0.0_alpha12/work/openjdk/control/build/linux-amd64/tmp/sun/com.sun.java.util.jar.pack/unpack-cmd/obj64 /main.o:
In function `setup_gzin':
[exec] /var/tmp/portag/dev-java/openjdk-1.7.0.0_alpha12/work/openjdk/j2se/make/com/sun/java/pack/../../../../../src/share/native/com/sun/java/util /jar/pack/main.cpp:129:
undefined reference to
`gunzip::init(unpacker*)' [exec] /var/tmp/portag/dev-java/openjdk-1.7.0.0_alpha12/work/openjdk/control/build/linux-amd64/tmp/sun/com.sun.java.util.jar.pack/unpack-cmd/obj64 /main.o:
In function `unpacker::run(int, char**)':
[exec] /var/tmp/portag/dev-java/openjdk-1.7.0.0_alpha12/work/openjdk/j2se/make/com/sun/java/pack/../../../../../src/share/native/com/sun/java/util /jar/pack/main.cpp:377:
undefined reference to `gunzip::start(int)' [exec] collect2: ld
returned 1 exit status [exec] make[7]: ***
[/var/tmp/portag/dev-java/openjdk-1.7.0.0_alpha12/work/openjdk/control/build/linux-amd64/bin/unpack200]
Error 1


The problem is that -DNO_ZLIB is set on a first pass, where
STANDALONE=yes is used on the make call; with OTHER_CXXFLAGS being an
environment variable, the value is not removed when getting out of that
pass, and is kept over during unpack200 build.

The attached patch uses CXXFLAGS_COMMON instead, and allows the build
to complete safely when setting the the value in environment.

-- 
Diego "Flameeyes" Pettenò
http://farragut.flameeyes.is-a-geek.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openjdk-j2se-cxxflags.patch
Type: text/x-patch
Size: 459 bytes
Desc: not available
URL: <https://mail.openjdk.org/pipermail/build-dev/attachments/20070511/62a3961e/openjdk-j2se-cxxflags.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <https://mail.openjdk.org/pipermail/build-dev/attachments/20070511/62a3961e/signature.asc>