sh files in ProblemList (was Re: Need reviewers - jdk testing changes 6888927)

Kelly O'Hair Kelly.Ohair at Sun.COM
Mon Nov 9 18:51:38 UTC 2009


I just now am fixing some demo/jvmti tests, which seemed to fail
with samevm and pass with othervm, the problem seemed to be that
when run with samevm, the current directory (user.dir) is different.

So if a test is assuming anything about the current directory, that
could be an issue. But again, I didn't think that the shell tests
would be impacted even by this, since they would be run with othervm.

The samevm feature was pretty dusty before Jon started getting it
working again, so there may be misc minor issues involved with it.

But I think your shell tests may have been just problematic when multiple
instances of them are run on one machine, like a port number problem.
That's hard for me to diagnose quickly, so when tests failed with
any kind of BindException or 'address already in use', I just added
them to the list and moved on.

-kto

Max (Weijun) Wang wrote:
> Hi Kelly
> 
> I'm looking at the ProblemList.txt file, which contains some .sh files 
> in my area. I guess the .sh files should behave the same no matter if 
> -savevm is turned on, since it's always launched in another process. Am 
> I right?
> 
> These tests (except one) normally pass when I run them (even on JPRT on 
> all platforms). Can you show me how they fail on your system? say, a 
> list of jtr files I can look into?
> 
> Thanks
> Max
> 
> On Nov 7, 2009, at 6:57 AM, Kelly O'Hair wrote:
> 
>> Tim,
>>
>> I was going to push these test changes into the jdk7/build forest,
>> but maybe it makes more sense to push it into the jdk7/tl forest?
>> Any opinions on that?
>>
>> Fresh webrev:
>>  6888927: Fix jdk jtreg tests to indicate which ones need othervm, 
>> allow for use of samevm option
>>  http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-samevm-6888927/webrev/ 
>>
>>
>> I've run it maybe a dozen times now and the test list is starting
>> to stabilize.
>>
>> After I push it, I planned on working on fixing some of the
>> serviceability tests and get them off the ProblemList.
>> And that definitely seemed like a jdk7/tl change.
>>
>> ---
>>
>> All,
>>
>> Let me know who wants to be listed as a reviewer on this changeset.
>>
>> -kto
> 



More information about the build-dev mailing list