Need reviewers and comments: 6989472: Provide simple jdk identification information in the install image

David Schlosnagle schlosna at gmail.com
Wed Dec 1 03:31:55 UTC 2010


On Tue, Nov 30, 2010 at 8:34 PM, Kelly O'Hair <kelly.ohair at oracle.com> wrote:
> A revised proposal...
>
> Still called "jdk.release".
> But if people really think "jdk.properties" sounds ok, at least the names
> are unique and won't conflict.
>
>  http://cr.openjdk.java.net/~ohair/openjdk7/jdk_release2/webrev/
>
> A Linux 64bit build should result in a jdk.release file that looks something
> like:
>
> jdk.os.name = Linux
> jdk.os.version = 2.6
> jdk.os.arch = amd64
> jdk.java.version = 1.7.0
> jdk.vm.cfg.files = jre/lib/amd64/jvm.cfg
>
> -kto

Kelly,

I'm assuming the intention is to have a launcher such as Eclipse parse
the "jdk.release" file and look for the value of "jdk.vm.cfg.files",
and then parse that value. Is this a list of files separated by the
path.separator or some other string? Does the separator need to be
another property? Finally the launcher would parse each (jvm.cfg) file
and look for one of the JVMs (server, client, zero, cacao, hotspot,
etc.).

There seems to be a mismatch between the email's "jdk.java.version"
and webrev's "jdk.version" in Release.gmk line 521:
 508 # Common way to emit a line into $(JDK_INFO_FILE)
 509 define jdk-info-file # name value
 510 $(PRINTF) "jdk.%s = %s\n" $1 $2 >> $@
                    ^
... snip ...
 519 $(JDK_INFO_FILE): FRC
 520         $(prep-target)
 521         $(call jdk-info-file, "version",      "$(THIS_JDK_VERSION)")
                                    ^

- Dave



More information about the build-dev mailing list