Need reviewers and comments: 6989472: Provide simple jdk identification information in the install image

[Kelly O'Hair]

On Nov 30, 2010, at 7:31 PM, David Schlosnagle wrote:

> On Tue, Nov 30, 2010 at 8:34 PM, Kelly O'Hair  
> <kelly.ohair at oracle.com> wrote:
>> A revised proposal...
>>
>> Still called "jdk.release".
>> But if people really think "jdk.properties" sounds ok, at least the  
>> names
>> are unique and won't conflict.
>>
>>  http://cr.openjdk.java.net/~ohair/openjdk7/jdk_release2/webrev/
>>
>> A Linux 64bit build should result in a jdk.release file that looks  
>> something
>> like:
>>
>> jdk.os.name = Linux
>> jdk.os.version = 2.6
>> jdk.os.arch = amd64
>> jdk.java.version = 1.7.0
>> jdk.vm.cfg.files = jre/lib/amd64/jvm.cfg
>>
>> -kto
>
> Kelly,
>
> I'm assuming the intention is to have a launcher such as Eclipse parse
> the "jdk.release" file and look for the value of "jdk.vm.cfg.files",
> and then parse that value. Is this a list of files separated by the
> path.separator or some other string? Does the separator need to be
> another property? Finally the launcher would parse each (jvm.cfg) file
> and look for one of the JVMs (server, client, zero, cacao, hotspot,
> etc.).

Yes, you get the idea. I was planning on just using a space separator,  
but could use whatever
people think would be best. The path.separator being different between  
platforms (windows/unix)
isn't helpful in my opinion.
In most systems I have seen, there would only be one jvm.cfg file.  
Solaris does provide
two on most of it's installs. But I wanted to allow for multiple ones.

>
> There seems to be a mismatch between the email's "jdk.java.version"

Ah... my example was a mistake, I intended to use jdk.version.

-kto

> and webrev's "jdk.version" in Release.gmk line 521:
> 508 # Common way to emit a line into $(JDK_INFO_FILE)
> 509 define jdk-info-file # name value
> 510 $(PRINTF) "jdk.%s = %s\n" $1 $2 >> $@
>                    ^
> ... snip ...
> 519 $(JDK_INFO_FILE): FRC
> 520         $(prep-target)
> 521         $(call jdk-info-file, "version",      "$ 
> (THIS_JDK_VERSION)")
>                                    ^
>
> - Dave