Need reviewer

Kelly O'Hair kelly.ohair at oracle.com
Sat Jul 23 00:29:35 UTC 2011


On Jul 22, 2011, at 5:09 PM, David Katleman wrote:

> 
> 
> On 7/22/2011 4:57 PM, Kelly O'Hair wrote:
>> 
>> Can one of you review these jprt changes, there is no impact to RE or manual developer building.
>> 
>> These changes are needed to instruct our internal developer build system JPRT on how to build jdk8.
>> 
>> 7069993: Adjust make/jprt.properties file for jdk8
>> http://cr.openjdk.java.net/~ohair/openjdk8/jprt-changes/webrev/
> 
> Couldn't see any problems with the changes.
> 
>>   34 # Standard list of jprt build targets for this source tree
>>   35 jprt.build.targets=                                             \
>>   36     solaris_sparc_5.10-{product|fastdebug},                     \
>>   37     solaris_sparcv9_5.10-{product|fastdebug},                   \
>>   38     solaris_i586_5.10-{product|fastdebug},                      \
>>   39     solaris_x64_5.10-{product|fastdebug},                       \
>>   40     linux_i586_2.6-{product|fastdebug},                         \
>>   41     linux_x64_2.6-{product|fastdebug},                          \
>>   42     windows_i586_5.1-{product|fastdebug},                       \
>>   43     windows_x64_5.2-{product|fastdebug
> Shame there isn't a way to have the above included instead of repeated everywhere.

Yeah, this may change when we start building more platforms in jdk8, embedded and also bsd and mac
builds might be done.  But we aren't quite ready for that yet, so the best thing was to explicitly list the
ones that build now.

-kto

> 
> Consider the code reviewed!
> 
>         Dave
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/build-dev/attachments/20110722/35c68f24/attachment.htm>


More information about the build-dev mailing list