Request for review: always generate java-rmi.cgi

David Katleman david.katleman at oracle.com
Thu May 12 01:59:10 UTC 2011



On 5/11/2011 6:50 PM, Kelly O'Hair wrote:
> Please review this change:
>
> 7043921: generate java-rmi.cgi on 64 bit platform
> http://cr.openjdk.java.net/~ohair/openjdk7/java-rmi-7043921/webrev/
>
> I think this works for you guys, and seems to be a bit more obvious, at least to me. ;^)

Was this review simply to take the existing code, do the same exact  
thing, but in a more readable fashion?

If so, linux is missing it's "ifeq ($(ARCH_DATA_MODEL), 32)"

If the change is to include "bin" on all linux platforms now, then it's 
just fine, and much more readable.

         Dave




More information about the build-dev mailing list