Request for review: always generate java-rmi.cgi

Kelly O'Hair kelly.ohair at oracle.com
Thu May 12 02:00:16 UTC 2011


On May 11, 2011, at 6:59 PM, David Katleman wrote:

> 
> 
> On 5/11/2011 6:50 PM, Kelly O'Hair wrote:
>> Please review this change:
>> 
>> 7043921: generate java-rmi.cgi on 64 bit platform
>> http://cr.openjdk.java.net/~ohair/openjdk7/java-rmi-7043921/webrev/
>> 
>> I think this works for you guys, and seems to be a bit more obvious, at least to me. ;^)
> 
> Was this review simply to take the existing code, do the same exact  thing, but in a more readable fashion?

No. The linux 64bit builds were missing a file.

> 
> If so, linux is missing it's "ifeq ($(ARCH_DATA_MODEL), 32)"
> 
> If the change is to include "bin" on all linux platforms now, then it's just fine, and much more readable.

That is the case. Linux always gets it.

-kto

> 
>        Dave
> 




More information about the build-dev mailing list