Review Request: openjdk make changes for "CR 7099017: jdk7u2-dev does not build"

Chris Gruszka chris.gruszka at oracle.com
Mon Oct 17 21:27:11 UTC 2011


Phil,
More like only include ifndef OPENJDK, so an OPENJDK build with closed 
forests will not include the files.

-ChrisG

On 10/17/2011 5:15 PM, Phil Race wrote:
> On 10/17/2011 2:13 PM, Phil Race wrote:
>> Looks fine to me .. I assume that building these moved to be in 
>> tandem with their existence.
>
> A better word than "assume" is"interpret" ..
>
> -phil.
>
>>
>> -phil.
>>
>> On 10/17/2011 1:54 PM, chris.gruszka at oracle.com wrote:
>>> I am still looking for a reviewer.
>>>
>>> Please,
>>> -ChrisG
>>>
>>> On 10/13/2011 5:03 PM, chris.gruszka at oracle.com wrote:
>>>> openjdk make changes to skip demo/DEMOS_LICENSE and 
>>>> sample/SAMPLES_LICENSE when building OPENJDK
>>>>
>>>> The webrev can be found at:
>>>> http://cr.openjdk.java.net/~cgruszka/7099017/ 
>>>> <http://cr.openjdk.java.net/%7Ecgruszka/7099017/>
>>>>
>>>> JPRT East builds of the open forest 
>>>> (2011-10-13-033517.cg207731.jdk7u-dev) and the closed forest 
>>>> (2011-10-13-035341.cg207731.7u-7099017) verify the change.
>>>> OpenJDK builds fine.  Closed Demo bundles contain the 
>>>> demo/DEMOS_LICENSE and sample/SAMPLES_LICENSE files.
>>>>
>>>> -ChrisG
>>>>
>>
>



More information about the build-dev mailing list