RFR: 7181175 Enable hotspot builds on Windows with MinGW/MSYS
Daniel D. Daugherty
daniel.daugherty at oracle.com
Thu Aug 2 21:20:24 UTC 2012
On 8/2/12 11:30 AM, Tim Bell wrote:
> Ping? I need someone on hotspot-runtime to sponsor this change and
> shepherd it through a JPRT push:
>
> http://cr.openjdk.java.net/~tbell/7181175/webrev.01/
make/windows/makefiles/defs.make
No comments.
make/windows/makefiles/rules.make
lines 28-33: Might want to comment on why these paths still
use backslash instead of forward slash.
make/windows/makefiles/sa.make
lines 88, 90:
These lines drop the "/YX" option instead of changing it to "-YX".
line 97:
This line adds back the "-Z" option and drops the "/YX" option
instead of changing it to "-YX".
The "-Z" option is conditionally added on line 99.
line 106:
This line adds back the "-map -debug" options.
The "-map" and "-debug" options are conditionally added on line
108.
make/windows/makefiles/shared.make
line 43: Might want to comment on why these paths still
use backslash instead of forward slash.
>
> I believe I have addressed the review feedback received so far, and
> I'd like to get this off my desk so I can focus on build-infra work.
>
> Thanks in advance-
>
> Tim
>
>
> On 07/19/12 15:35, Tim Bell wrote:
>> I wrote:
>>> My test build is running now. I'll update the webrev and send out a
>>> new URL.
>>
>> The test builds were successful. I also ran full hotspot builds on
>> JPRT using '-release jdk8' and '-release jdk7u6', so there is no
>> regression in the old builds. I believe I have addressed the review
>> feedback received so far:
>>
>> http://cr.openjdk.java.net/~tbell/7181175/webrev.01/
>>
>> Thanks-
>>
>> Tim
>>
>>> http://mail.openjdk.java.net/pipermail/build-dev/2012-March/005729.html
>>> http://cr.openjdk.java.net/~simonis/MinGW_MSYS_hotspot.v1/
>>
>>
>
>
More information about the build-dev
mailing list