Review Request: 8004490: build-infra: mac: hotspot is always built in product, regardless of --with-debug-level setting
Tim Bell
tim.bell at oracle.com
Fri Dec 28 15:39:34 UTC 2012
Looks good to me.
Tim
On 12/28/12 04:39, Erik Joelsson wrote:
> I picked the variable that will have the values that match the targets
> in hotspot. The difference is jvmg vs debug. For other platforms, the
> target list will look something like:
>
> jvmg jvmg1 docs export_debug
>
> For mac it's just:
>
> universal_debug
>
> The universal targets for mac aren't on the same level as the targets
> used for the other platforms.
>
> /Erik
>
> On 2012-12-28 13:22, David Holmes wrote:
>> On 28/12/2012 8:48 PM, Erik Joelsson wrote:
>>> Small fix for setting the correct hotspot target when building debug.
>>>
>>> http://cr.openjdk.java.net/~erikj/8004490/webrev.01/
>>
>> Why is it:
>>
>> HOTSPOT_TARGET=universal_${HOTSPOT_EXPORT}
>>
>> not
>>
>> HOTSPOT_TARGET=universal_${HOTSPOT_DEBUG_LEVEL}
>>
>> ?
>>
>> David
>>
>>> /Erik
>
More information about the build-dev
mailing list