Need reviewer: corba changes for build infra

Tim Bell tim.bell at gmail.com
Tue Mar 13 05:14:47 UTC 2012


Hi Kelly

> Need a reviewer for these build-infra changes to the strip properties utility in the corba repository.
>
> 7153266: Adjustments to corba strip property utility (neutral to builds)
> http://cr.openjdk.java.net/~ohair/openjdk8/infra-corba/webrev/

Looks good overall.

I find this is a bit alarming - won't it overwrite the input file with
the output file?

 120             String infile = inIter.next();
 121             String outfile = outIter.next();


Note this would have happened in the earlier version as well:

 118                 in = new BufferedInputStream(new FileInputStream(file));
   [...]
 141                 out = new FileOutputStream(file);

If these are derived files anyhow, maybe this is a non-issue.

Regards-

Tim



More information about the build-dev mailing list