Need reviewer: corba changes for build infra

Tim Bell tim.bell at gmail.com
Tue Mar 13 05:30:35 UTC 2012


I wrote:

> I find this is a bit alarming - won't it overwrite the input file with
> the output file?
>
>  120             String infile = inIter.next();
>  121             String outfile = outIter.next();

Sorry, I meant to pick on these lines, and also mention that
args.length should be an even number at line 64...

 107                 infiles.add(args[i]);
 108                 outfiles.add(args[i]);

Otherwise, my remarks apply, FWIW.

TIm


> Note this would have happened in the earlier version as well:
>
>  118                 in = new BufferedInputStream(new FileInputStream(file));
>   [...]
>  141                 out = new FileOutputStream(file);
>
> If these are derived files anyhow, maybe this is a non-issue.
>
> Regards-
>
> Tim



More information about the build-dev mailing list