Review Request: 8002028: build-infra: need no-hotspot partial build

David Holmes david.holmes at oracle.com
Thu Nov 8 03:19:24 UTC 2012


Hi Erik,

Two queries:

1. In Main.gmk wouldn't it be better to move the hotspot targets inside 
the conditional - that way if you ask to build hotspot when you are not 
configured to build it you will get an error.

2. Why do you have to import hotspot from a full JDK ??

David

On 8/11/2012 1:08 AM, Erik Joelsson wrote:
> Adding support for importing the hotspot binaries from a prebuilt j2sdk
> image. Use configure option --with-import-hotspot=/path/to/j2sdkimage
> and the build will skip building hotspot.
>
> http://cr.openjdk.java.net/~erikj/8002028/webrev.jdk.01/
> <http://cr.openjdk.java.net/%7Eerikj/8002028/webrev.jdk.01/>
> http://cr.openjdk.java.net/~erikj/8002028/webrev.root.01/
> <http://cr.openjdk.java.net/%7Eerikj/8002028/webrev.root.01/>
>
> Note that if trying this patch (or before committing it) make sure to
> regenerate configure first and if committing, commit in jdk/make/closed
> too.
>
> /Erik



More information about the build-dev mailing list