Review Request: 8002028: build-infra: need no-hotspot partial build

[Erik Joelsson]

On 2012-11-08 04:19, David Holmes wrote:
> Hi Erik,
>
> Two queries:
>
> 1. In Main.gmk wouldn't it be better to move the hotspot targets 
> inside the conditional - that way if you ask to build hotspot when you 
> are not configured to build it you will get an error.
>
I figured there would be errors when other targets depended on hotspot, 
but it seems to handle it fine. In fact, I can't get it to cause any 
errors at all even when trying to make hotspot explicitly. It looks 
better having the complete set of rules inside the ifdefs though.

> 2. Why do you have to import hotspot from a full JDK ??
>
You don't. I just assumed that's how this feature was used before. 
Another valid value would be the dist directory of any hotspot build. 
Are there other possible ways to use this in the old build?

/Erik
> David
>
> On 8/11/2012 1:08 AM, Erik Joelsson wrote:
>> Adding support for importing the hotspot binaries from a prebuilt j2sdk
>> image. Use configure option --with-import-hotspot=/path/to/j2sdkimage
>> and the build will skip building hotspot.
>>
>> http://cr.openjdk.java.net/~erikj/8002028/webrev.jdk.01/
>> <http://cr.openjdk.java.net/%7Eerikj/8002028/webrev.jdk.01/>
>> http://cr.openjdk.java.net/~erikj/8002028/webrev.root.01/
>> <http://cr.openjdk.java.net/%7Eerikj/8002028/webrev.root.01/>
>>
>> Note that if trying this patch (or before committing it) make sure to
>> regenerate configure first and if committing, commit in jdk/make/closed
>> too.
>>
>> /Erik