Review request: Build infra update
Erik Joelsson
erik.joelsson at oracle.com
Tue Oct 9 11:13:27 UTC 2012
On 2012-10-09 12:59, David Holmes wrote:
> On 9/10/2012 6:06 PM, Erik Joelsson wrote:
>> Not exactly sure what you mean with the duplication other than the
>> comment in the last rule being wrong. One rule is for copying from
>> jdk/lib and the other from images/lib. Both sources contain files that
>> are going into the image.
>
> I thought you were only allowed to define one recipe per target? Or
> are we going to find disjoint sets of files in each location?
>
> These wildcard based targets and dependencies still cause me some
> confusion. I don't understand what process make follows to actually
> determine what the real set of targets is.
>
My assumption is that the sets are disjoint yes. I'm not completely sure
of the process either, but figured that as long as the sets are
disjoint, it will be fine. Also, if they are not, we have a problem
regardless imo.
I do agree I might have gone a bit too wild with the pattern targets in
this case though.
/Erik
More information about the build-dev
mailing list