Review request: Build infra update

[David Holmes]

On 9/10/2012 9:13 PM, Erik Joelsson wrote:
> On 2012-10-09 12:59, David Holmes wrote:
>> On 9/10/2012 6:06 PM, Erik Joelsson wrote:
>>> Not exactly sure what you mean with the duplication other than the
>>> comment in the last rule being wrong. One rule is for copying from
>>> jdk/lib and the other from images/lib. Both sources contain files that
>>> are going into the image.
>>
>> I thought you were only allowed to define one recipe per target? Or
>> are we going to find disjoint sets of files in each location?
>>
>> These wildcard based targets and dependencies still cause me some
>> confusion. I don't understand what process make follows to actually
>> determine what the real set of targets is.
>>
> My assumption is that the sets are disjoint yes. I'm not completely sure
> of the process either, but figured that as long as the sets are
> disjoint, it will be fine. Also, if they are not, we have a problem
> regardless imo.

So the process is, as I understand it, for every file that matches the 
dependency pattern a target for that file, in the output-location, is 
created and the recipe then copies from src to destination.

As you say the two sets of input files should be distinct so there are 
no duplicates in the set of targets formed. (Though if you don't do a 
clean before rebuilding with this patch applied things might get a bit 
confused :) ).

> I do agree I might have gone a bit too wild with the pattern targets in
> this case though.

:) Not sure how else you could define these generic copying routines.

Thanks,
David

> /Erik