Support building zero with the new build
Andrew Hughes
gnu.andrew at redhat.com
Wed Apr 3 14:54:58 UTC 2013
----- Original Message -----
> Yup, fine for me as well! (I'm not a reviewer though... just an opinion)
>
> Roman
>
> Am Mittwoch, den 03.04.2013, 10:28 +0200 schrieb Erik Joelsson:
> > This looks good to me. Thanks!
> >
> > /Erik
> >
> > On 2013-04-02 23:17, Omair Majid wrote:
> > > Hi,
> > >
> > > Updated patch at:
> > > http://cr.openjdk.java.net/~omajid/webrevs/zero-newbuild/02/
> > >
> > > On 04/02/2013 05:21 AM, Erik Joelsson wrote:
> > >> I know it's not always obvious where things belong but I would put the
> > >> INCLUDE_SA logic in jdk-options.m4 somewhere close after the JVM_VARIANT
> > >> variables have been assigned.
> > > How about right after it? :)
> > >
> > > Thanks,
> > > Omair
> > >
>
>
>
It looks fine to me from reading the patch, but I'll give it a test run.
Do we have a bug ID? Assuming I don't find any issues, we should be good to go.
--
Andrew :)
Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
More information about the build-dev
mailing list