Support building zero with the new build
Erik Joelsson
erik.joelsson at oracle.com
Wed Apr 3 15:17:08 UTC 2013
On 2013-04-03 16:54, Andrew Hughes wrote:
> ----- Original Message -----
>> Yup, fine for me as well! (I'm not a reviewer though... just an opinion)
>>
>> Roman
>>
>> Am Mittwoch, den 03.04.2013, 10:28 +0200 schrieb Erik Joelsson:
>>> This looks good to me. Thanks!
>>>
>>> /Erik
>>>
>>> On 2013-04-02 23:17, Omair Majid wrote:
>>>> Hi,
>>>>
>>>> Updated patch at:
>>>> http://cr.openjdk.java.net/~omajid/webrevs/zero-newbuild/02/
>>>>
>>>> On 04/02/2013 05:21 AM, Erik Joelsson wrote:
>>>>> I know it's not always obvious where things belong but I would put the
>>>>> INCLUDE_SA logic in jdk-options.m4 somewhere close after the JVM_VARIANT
>>>>> variables have been assigned.
>>>> How about right after it? :)
>>>>
>>>> Thanks,
>>>> Omair
>>>>
>>
>>
> It looks fine to me from reading the patch, but I'll give it a test run.
>
> Do we have a bug ID? Assuming I don't find any issues, we should be good to go.
JDK-8011388: Support building zero and zeroshark with the new build
/Erik
More information about the build-dev
mailing list