Review Request: JDK-8009196 install doesn't define $(AR) as /usr/ccs/bin/ar, results in ar: Command not found

Tim Bell tim.bell at oracle.com
Thu Feb 28 20:25:17 UTC 2013


Hi Dave

Don't you need to address the other file as well 
(make/common/shared/Compiler-msvc.gmk) by moving the endif from 91 up to 
line 40?

Seems like the version checks will not be filled in and the Windows 
build should fail the sanity check.  Do the release builds run sanity 
checks?

Tim

On 02/28/13 11:42, David Katleman wrote:
> Modification to an earlier fix which broke internal Solaris builds, 
> because ar could not be found.
>
> Rather than the hatchet Erik's fix took to the problem, separating the 
> CROSS_COMPILE_ARCH portion into it's own if, and the second portion 
> into it's own Solaris only if since the ccs path is valid only on 
> Solaris, and the original fix was to avoid this whole section for 
> Windows.
>
>     http://cr.openjdk.java.net/~katleman/8009196/webrev.jdk.01/
>
> For reference, the original fix
>
>     http://cr.openjdk.java.net/~erikj/8007903/webrev.jdk.01/
>
> Thanks
>         Dave





More information about the build-dev mailing list