Review Request: JDK-8009196 install doesn't define $(AR) as /usr/ccs/bin/ar, results in ar: Command not found

[David Katleman]

On 2/28/2013 12:25 PM, Tim Bell wrote:
> Hi Dave
>
> Don't you need to address the other file as well 
> (make/common/shared/Compiler-msvc.gmk) by moving the endif from 91 up 
> to line 40?

Since the original fix was to address windows build issues, and windows 
builds fine, I left Compiler-msvc.gmk alone, the entire section is 
windows only.

In Defs-utils.gmk, that whole section was buggy, since if 
CROSS_COMPILE_ARCH wasn't defined, we automatically set those 5 
definitions to something very Solaris specific?

Using CONFIGURE_BUILD was a windows bandaid that happened to build 
everywhere (but only if /usr/ccs/bin was in your path for Solaris)

> Seems like the version checks will not be filled in and the Windows 
> build should fail the sanity check.  Do the release builds run sanity 
> checks?

Yes, we run the sanity checks (kitchen sink)

                 Dave
> On 02/28/13 11:42, David Katleman wrote:
>> Modification to an earlier fix which broke internal Solaris builds, 
>> because ar could not be found.
>>
>> Rather than the hatchet Erik's fix took to the problem, separating 
>> the CROSS_COMPILE_ARCH portion into it's own if, and the second 
>> portion into it's own Solaris only if since the ccs path is valid 
>> only on Solaris, and the original fix was to avoid this whole section 
>> for Windows.
>>
>>     http://cr.openjdk.java.net/~katleman/8009196/webrev.jdk.01/
>>
>> For reference, the original fix
>>
>>     http://cr.openjdk.java.net/~erikj/8007903/webrev.jdk.01/
>>
>> Thanks
>>         Dave
>
>