RFR: 8015759: hotspot changes needed to compile with Visual Studio 2012

[Anthony Petrov]

Tim:
Thanks for fixing this! The changes look good to me. The only minor 
concern is with the following:

make/windows/makefiles/vm.make
>  143 # VS2012 requires this object file to be listed:
>  144 LD_FLAGS=$(LD_FLAGS) _build_pch_file.obj

I'm not sure if this is a VS2010- compatible change. There were some 
problems with this _build_pch_file.obj, but I can't recall the details. 
Can we make this conditional, like !if "$(MSC_VER)" >= "1700"?


David:
The _STATIC_CPPLIB not working means that the msvcp110.dll (C++ Runtime) 
needs to be redistributed along with the msvcr110.dll (C Runtime). Since 
both JDK and HotSpot (and FX, for that matter) use C++ libraries, it 
seems reasonable to redistribute this dll.

--
best regards,
Anthony

On 06/03/13 10:13, David Holmes wrote:
> Hi Tim,
>
> In compile.make:
>
> Please update copyright end year to 2013 (hotspot-runtime process rule).
>
> I'm wondering what the impact is of not being able to use
> _STATIC_CPPLIB? Given it has been deprecated for a while was it actually
> a no-op? We need to understand what impact this has, if any, on the
> built bits.
>
> ---
>
> In sanity.make:
>
> Please update copyright end year to 2013
>
> ---
>
> In vm.make this addition seems unrelated to a compiler change:
>
> !ifdef RELEASE
> + !ifdef DEVELOP
> + CXX_FLAGS=$(CXX_FLAGS) /D "DEBUG"
> + !else
> CXX_FLAGS=$(CXX_FLAGS) /D "PRODUCT"
> + !endif
> !else
> CXX_FLAGS=$(CXX_FLAGS) /D "ASSERT"
> !endif
>
> What is a RELEASE+DEVELOP build? Further I would expect that any build
> that sets DEBUG should also set ASSERT ??
>
> ---
>
> In unwind_windows_x86.hpp
>
> Please update copyright end year to 2013
>
> ---
>
> I'd be happy to sponsor the push into hotspot-rt once this is finalized.
> Just create the changeset and send me a link to it.
>
> Thanks,
> David
>
> On 2/06/2013 3:02 AM, Tim Bell wrote:
>> 8015759: hotspot changes needed to compile with Visual Studio 2012
>>
>> The bug report will be visible in a few days here:
>> http://bugs.sun.com/view_bug.do?bug_id=8015759
>>
>> Minor Makefile changes and one source file was touched to compile with
>> Visual Studio 2012. These changes also compile under
>> Visual Studio 2010 with no problem so we can upgrade gracefully. Tested
>> by building the forest with both compilers.
>>
>> % hg status
>> M make/windows/makefiles/compile.make
>> M make/windows/makefiles/sanity.make
>> M make/windows/makefiles/vm.make
>> M src/os_cpu/windows_x86/vm/unwind_windows_x86.hpp
>>
>> webrev and patch file are here:
>>
>> http://cr.openjdk.java.net/~tbell/8015759/hotspot/webrev.00/
>> http://cr.openjdk.java.net/~tbell/8015759/hotspot/webrev.00/hotspot.patch
>>
>> Thanks to Anthony Petrov who provided the initial set of patches for
>> this work.
>>
>> I believe this should go in via the hotspot-rt forest (let me know if
>> that is not correct), in which case I will need a sponsor from that team
>> to push the change.
>>
>> Thanks in advance-
>> Tim
>>