RFR: 8015759: hotspot changes needed to compile with Visual Studio 2012

[Daniel D. Daugherty]

On 6/1/13 11:02 AM, Tim Bell wrote:
> 8015759: hotspot changes needed to compile with Visual Studio 2012
>
> The bug report will be visible in a few days here:
> http://bugs.sun.com/view_bug.do?bug_id=8015759
>
> Minor Makefile changes and one source file was touched to compile with 
> Visual Studio 2012.  These changes also compile under
> Visual Studio 2010 with no problem so we can upgrade gracefully. 
> Tested by building the forest with both compilers.
>
> % hg status
> M make/windows/makefiles/compile.make

     same question about the STATIC_CPPLIB stuff as David H.


> M make/windows/makefiles/sanity.make

     No comments.


> M make/windows/makefiles/vm.make

     Same question about the new 'ifdef DEVELOP' change as David H.

     Sanity check: The patch shows this change:

  # Special case files not using precompiled header files.

-c1_RInfo_$(Platform_arch).obj: 
$(WorkSpace)\src\cpu\$(Platform_arch)\vm\c1_RInfo_$(Platform_arch).cpp
+c1_RInfo_$(Platform_arch).obj: 
$(WorkSpace)\src\cpu\$(Platform_arch)\vm\c1_RInfo_$(Platform_arch).cpp
       $(CXX) $(CXX_FLAGS) $(CXX_DONT_USE_PCH) /c 
$(WorkSpace)\src\cpu\$(Platform_arch)\vm\c1_RInfo_$(Platform_arch).cpp

     But I don't see a change. And this diff doesn't show up in the
     other views.  Oh wait, there's a blank at the end of the '+'
     line...

> M src/os_cpu/windows_x86/vm/unwind_windows_x86.hpp

     No comments.

Dan


>
> webrev and patch file are here:
>
> http://cr.openjdk.java.net/~tbell/8015759/hotspot/webrev.00/
> http://cr.openjdk.java.net/~tbell/8015759/hotspot/webrev.00/hotspot.patch
>
> Thanks to Anthony Petrov who provided the initial set of patches for 
> this work.
>
> I believe this should go in via the hotspot-rt forest (let me know if 
> that is not correct), in which case I will need a sponsor from that 
> team to push the change.
>
> Thanks in advance-
> Tim
>
>