Disable overrides during jdk build

[Alan Bateman]

No objection although it feels like we are going backwards rather than 
forwards.

I submitted a few bugs on this topic recently as it seems to me that 
there aren't too many override warnings to kill off. Daniel Fuchs has a 
patch out for review today that fixes these warnings in the jaxp 
repository. The overrides warnings were also fixed in the jaxws 
repository as part of the bulk update a few weeks ago. That leaves 12 
for the corba repository and about 29 in the jdk repository (29 on Linux 
at least, it varies by platform).

I completely agree with you that the noise is high. On several occasions 
I've had to edit the build log to find the errors when they get lots in 
the warnings. I just wonder whether we should just fix what seems like a 
small number of warnings.

-Alan


On 13/05/2013 14:53, Chris Hegarty wrote:
> Please hold your fire! This is not a suggestion to about general 
> handling of warnings during the build, just a specific gripe I have 
> when trying to find genuine build failures among the noise.
>
> Would there be any objection to adding '-overrides' to the jdk build?
>
> This lint warning was added after the new build was introduced. I 
> suspect it would have been suppressed originally if it was supported 
> at the time.
>
> diff --git a/makefiles/Setup.gmk b/makefiles/Setup.gmk
> --- a/makefiles/Setup.gmk
> +++ b/makefiles/Setup.gmk
> @@ -23,7 +23,7 @@
>  # questions.
>  #
>
> -DISABLE_WARNINGS:=-Xlint:all,-deprecation,-unchecked,-rawtypes,-cast,-serial,-dep-ann,-static,-fallthrough,-try,-varargs,-empty,-finally 
>
> +DISABLE_WARNINGS:=-Xlint:all,-deprecation,-unchecked,-rawtypes,-cast,-serial,-dep-ann,-static,-fallthrough,-try,-varargs,-empty,-finally,-overrides 
>
>
>  # The generate old bytecode javac setup uses the new compiler to 
> compile for the
>  # boot jdk to generate tools that need to be run with the boot jdk.
>
> -Chris.
>
> P.S. how to handle warnings generally will have to be addressed at 
> some point, but I am not making any proposal at this time.