Disable overrides during jdk build

[Erik Joelsson]

On 2013-05-21 22:49, Andrew Hughes wrote:
> ----- Original Message -----
>> On 13/05/2013 15:24, Maurizio Cimadamore wrote:
>>> I think it makes sense, esp. if the messages appear to be redundant. The
>>> compiler logic is very strict and there are cases where it comes down to
>>> guessing user intent and compilers are notoriously bad at doing that. In
>>> the long term, I'd like to see @SuppressWarnings("overrides") applied in
>>> those cases where the impl knows what it's doing.
>> Agreed. Tackling warnings, on a per area basis, is something that we
>> need to spend more time on.
>>
>> I have not taken a look at the reason for the specific overrides
>> warnings. It is just that it appears the intent of the new build was to
>> suppress as many warnings as necessary, to make the output reasonable.
>> Since this warning was not in existence at the time, I could not be
>> suppressed.
>>
>> @SuppressWarnings("overrides") can be added, where appropriate, during
>> future warning cleanup events.
>>
> Is there an option in the new build to turn on all warnings, as there
> was in the old (JAVAC_MAX_WARNINGS if I recall correctly)?
>
No, this is currently missing.

/Erik
>> -Chris.
>>
>>> Maurizio
>>>
>>> On 13/05/13 14:53, Chris Hegarty wrote:
>>>> Please hold your fire! This is not a suggestion to about general
>>>> handling of warnings during the build, just a specific gripe I have
>>>> when trying to find genuine build failures among the noise.
>>>>
>>>> Would there be any objection to adding '-overrides' to the jdk build?
>>>>
>>>> This lint warning was added after the new build was introduced. I
>>>> suspect it would have been suppressed originally if it was supported
>>>> at the time.
>>>>
>>>> diff --git a/makefiles/Setup.gmk b/makefiles/Setup.gmk
>>>> --- a/makefiles/Setup.gmk
>>>> +++ b/makefiles/Setup.gmk
>>>> @@ -23,7 +23,7 @@
>>>> # questions.
>>>> #
>>>>
>>>> -DISABLE_WARNINGS:=-Xlint:all,-deprecation,-unchecked,-rawtypes,-cast,-serial,-dep-ann,-static,-fallthrough,-try,-varargs,-empty,-finally
>>>>
>>>> +DISABLE_WARNINGS:=-Xlint:all,-deprecation,-unchecked,-rawtypes,-cast,-serial,-dep-ann,-static,-fallthrough,-try,-varargs,-empty,-finally,-overrides
>>>>
>>>>
>>>> # The generate old bytecode javac setup uses the new compiler to
>>>> compile for the
>>>> # boot jdk to generate tools that need to be run with the boot jdk.
>>>>
>>>> -Chris.
>>>>
>>>> P.S. how to handle warnings generally will have to be addressed at
>>>> some point, but I am not making any proposal at this time.