Missing webrev features ( was Re: RFR: JDK-8027836 Webrev script breaks for files that has been moved from a directory which now is also removed)

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Thu Nov 7 13:26:44 UTC 2013


On 2013-11-06 03:01, Jonathan Gibbons wrote:
> Pwrhaps we should only have one copy of the webrev script around.

... and perhaps it should not be tied to a specific source branch. That 
has always seemed weird to me.

I would suggest creating a code-tools/webrev repository, and moving 
webrev.ksh there.

To keep backwards compatibility, it's relatively simple to replace 
make/script/webrev.ksh with a thin wrapper that does:

1) check for the existence of a hg repo in e.g. 
common/code-tools/webrev, and if not, clones it, otherwise, does a hg 
pull -u.
2) sanity checks that common/code-tools/webrev/webrev.ksh exists
3) calls common/code-tools/webrev/webrev.ksh with $@.

/Magnus



More information about the build-dev mailing list