Missing webrev features ( was Re: RFR: JDK-8027836 Webrev script breaks for files that has been moved from a directory which now is also removed)

[Jonathan Gibbons]

On 11/07/2013 05:26 AM, Magnus Ihse Bursie wrote:
> On 2013-11-06 03:01, Jonathan Gibbons wrote:
>> Pwrhaps we should only have one copy of the webrev script around.
>
> ... and perhaps it should not be tied to a specific source branch. 
> That has always seemed weird to me.
>
> I would suggest creating a code-tools/webrev repository, and moving 
> webrev.ksh there.
>
> To keep backwards compatibility, it's relatively simple to replace 
> make/script/webrev.ksh with a thin wrapper that does:
>
> 1) check for the existence of a hg repo in e.g. 
> common/code-tools/webrev, and if not, clones it, otherwise, does a hg 
> pull -u.
> 2) sanity checks that common/code-tools/webrev/webrev.ksh exists
> 3) calls common/code-tools/webrev/webrev.ksh with $@.
>
> /Magnus

Magnus,

It's not clear to me whether you mean a new repository within the 
standard existing code-tools project, or another repo in a JDK forest, 
in a "common" subdirectory.

How important is it to keep [compatibility with] make/script/webrev.ksh?

-- Jon