JI-9008287 - configure should provide better error reports about bootjvm binaries
David Holmes
david.holmes at oracle.com
Thu Nov 21 15:45:58 UTC 2013
On 22/11/2013 1:02 AM, Dave Pointon wrote:
> Hi again, Magnus ,
>
> On Fri, 2013-11-22 at 00:35 +1000, David Holmes wrote:
>> On 21/11/2013 11:05 PM, Magnus Ihse Bursie wrote:
>>> On 2013-11-19 13:47, Dave Pointon wrote:
>>>> The updated webrev can be found at
>>>> http://cr.openjdk.java.net/~ngmr/JI-9008287/webrev.02/
>>>
>>> The actual code looks better, but I'm not so sure about the copyright
>>> header. The actual change was indeed very small, and is more or less a
>>> variation of what I suggested earlier.
>>>
>>> If you insist on keeping it, I'll need to check with legal support
>>> first. Otherwise I think it looks good (but I'm not a formal reviewer).
>>
>> That is my position as a Reviewer as well.
>>
>> Meanwhile we should see about migrating the bug from JI to JDK.
>>
>> Thanks,
>> David
>>
>>> /Magnus
>>
>
> I've just received an update WRT the copyright change - it seems that I
> was inadvertently over zealous in the application of instructions and
> given the (lack of the) magnitude of the change, I should not have
> included the copyright statement.
>
> Would you like me to generate and indeed post, a new webrev ?
Please do. I moved the JI issue to JDK:
https://bugs.openjdk.java.net/browse/JDK-8028794
Not sure what your plans was for getting this pushed but we are in a
phase were an approval process has to be followed to make changes to 8.
The 9 forest will hopefully be open "real soon now" and this could be
backported to 8u after that.
Thanks,
David
>
> Rgds ,
>
More information about the build-dev
mailing list