RFR: JDK-8027068: Update to NewMakefile.gmk check of MAKE_VERSION broke jdk8-build nightly builds on windows, saying 3.82.90 is too low

David Katleman david.katleman at oracle.com
Tue Oct 22 23:31:43 UTC 2013


Thanks to Magnus, Brad, and Tim for the reviews.

That should be enough.

         Dave

On 10/22/2013 3:14 PM, David Katleman wrote:
> Please review this simple fix, addressing a problem with yesterday's 
> integration of JDK-8026528.
>
> NewMakefile.gmk was extended to recognize version 4 of make, but in 
> the process restricted older usage to exactly 3.81 & 3.82, which means 
> something like 3.82.90 is now flagged as too low.
>
> Both my windows builds now successfully pass beyond the 
> NewMakefile.gmk check, running Linux & Solaris builds to confirm there 
> as well.
>
> Bug:          https://bugs.openjdk.java.net/browse/JDK-8027068
> Webrev:   http://cr.openjdk.java.net/~katleman/8027068/webrev
>
> Thanks
>         Dave
>
>




More information about the build-dev mailing list