RFR: JDK-8027068: Update to NewMakefile.gmk check of MAKE_VERSION broke jdk8-build nightly builds on windows, saying 3.82.90 is too low

David Holmes david.holmes at oracle.com
Wed Oct 23 02:00:57 UTC 2013


On 23/10/2013 8:14 AM, David Katleman wrote:
> Please review this simple fix, addressing a problem with yesterday's
> integration of JDK-8026528.
>
> NewMakefile.gmk was extended to recognize version 4 of make, but in the
> process restricted older usage to exactly 3.81 & 3.82, which means
> something like 3.82.90 is now flagged as too low.
>
> Both my windows builds now successfully pass beyond the NewMakefile.gmk
> check, running Linux & Solaris builds to confirm there as well.
>
> Bug:          https://bugs.openjdk.java.net/browse/JDK-8027068
> Webrev:   http://cr.openjdk.java.net/~katleman/8027068/webrev

Works for me too. Reviewed.

Pity it will need updating again if there is a make 5 (and does make 
always use the M.N format eg 4.0 rather than 4 ?)

David

> Thanks
>          Dave
>
>



More information about the build-dev mailing list