Removal of the old build system, partial review

[David Holmes]

On 31/10/2013 1:01 AM, Alan Bateman wrote:
>
> I remember Kelly calling for hazard pay for anyone deleting code and
> triple pay for anyone deleting Makefile code.
>
> At a high level the plan looks reasonable. Aside from build tools then
> what else are you expecting to look at in step 2?
>
> So is the plan to do all of this in jdk8 before RDP2?

I think this is better targeted to 9 and 8u20. Any subtle mistakes are 
unlikely to show up until promoted builds are done by RE. This is not a 
P1-P3 issue.

David
-----

  If so then what
> would you think about pushing the changes to jdk8/tl rather than
> jdk8/build? I suggest pushing the changes to jdk8/tl because you are
> more likely to get more usage and testing before the changes go into
> jdk8. Also it helps to reduce conflicts (the white-spacing and split out
> of CompileNativeLibraries.gmk was disruptive).
>
> -Alan
>
> On 30/10/2013 14:22, Magnus Ihse Bursie wrote:
>> I have started working on removing the old build system. See
>> https://bugs.openjdk.java.net/browse/JDK-8027566.
>>
>> I plan do to this in several steps. I have not decided wether to
>> commit these steps as separate bugs, or just use this division to
>> facilitate developing and reviewing the fix. (Feedback on this
>> appreciated!)
>>
>> As a first step, I identified all files that was not used at all
>> anymore, and deleted these. The webrev I'm publishing here contains
>> these deletes.
>>
>> As a second step, I'm processing the remaining files and see why they
>> are still used, from where, and if they can move to better places. A
>> lot of them are only used in closed sources, and should therefore move
>> to the closed repositories. Some of them are used by the new build
>> system, and should be integrated into the new build system instead.
>>
>> Finally, I plan to move the new build system from "makefiles" to the
>> now-more-or-less-empty "make" directories. For a full rationale of
>> this, please see the JBS bug. In short: it makes no sense to have to
>> make directories, and we can't get rid of the "make" directory anyhow.
>>
>> But in this step is just the removal of the non-problematic parts of
>> the old build. If you see anything being removed here that should not
>> be, please let me now!
>>
>> Also, I have replaced the old top-level Makefile with the contents of
>> NewMakefile.gmk.
>>
>> (The .jcheck removals are just while I'm working, I couldn't find an
>> easy way to hide them in the webrev. I do not intend to check them in).
>>
>> WebRev:
>> http://cr.openjdk.java.net/~ihse/remove-old-build-part-1/webrev.02
>>
>> /Magnus
>>
>