RFR: ccache 3.1.9 not being recognized on Solaris

[Chris Hegarty]

On 10/31/2013 01:18 PM, Erik Joelsson wrote:
> While the change is correct, ccache usage on Solaris is pointless in my
> experience. Are you actually seeing performance gains by using it? I

When I originally got ccache hooked up I didn't see much ( if any ) 
improvement, but put this down to the cache being stored in my remote 
home directory. Since then, I've set CCACHE_DIR to a local filesystem, 
the results are marginal.

> investigated this quite thoroghly a while back and concluded that ccache
> and sun studio just didn't go together. I think I could make ccache work
> with sun studio, but it involves development work in the ccache
> application.

You are probably right. :-( I thought I had a silver bullet, no more 
looking at slow hotspot complies go by. It turns out not to be the case.

I can push the changes, or not. They work, as in they accept the right 
version, but are kind of pointless. At least now I know.

Thanks,
-Chris.

> I know historically ccache is present in jprt, but if you look at the
> stats posted at the end of each build, it's not getting any hits, which
> means it's just adding overhead and should be removed.
>
> /Erik
>
> On 2013-10-31 13:41, Chris Hegarty wrote:
>> Erik,
>>
>> I have a build of ccache 3.1.9 on my Solaris box, but it is not being
>> used by the build as it thinks it is not greater than 3.1.4.
>>
>> The suggested changes (below) are in line with the grep/regular
>> expression used in the GNU make version check you and Vinnie were
>> discussing yesterday. Additionally, a more informative notice is given
>> in the case where the version is not accepted.
>>
>> I suggest the following changes, with appropriate, and uninteresting,
>> updates to generated-configure.sh (s).
>>
>> diff -r 187a759c08ba common/autoconf/build-performance.m4
>> --- a/common/autoconf/build-performance.m4      Wed Oct 02 04:21:42
>> 2013 +0100
>> +++ b/common/autoconf/build-performance.m4      Thu Oct 31 12:30:46
>> 2013 +0000
>> @@ -197,8 +197,11 @@ AC_DEFUN([BPERF_SETUP_CCACHE_USAGE],
>>          # Only use ccache if it is 3.1.4 or later, which supports
>>          # precompiled headers.
>>          AC_MSG_CHECKING([if ccache supports precompiled headers])
>> -        HAS_GOOD_CCACHE=`($CCACHE --version | head -n 1 | grep -E
>> 3.1.@<:@456789@:>@) 2> /dev/null`
>> +
>> +        CCACHE_VERSION_STRING=`$CCACHE --version | head -n 1`
>> +        HAS_GOOD_CCACHE=`($ECHO $CCACHE_VERSION_STRING | $GREP -e
>> '3\.1\.[[456789]]') 2> /dev/null`
>>          if test "x$HAS_GOOD_CCACHE" = x; then
>> +            AC_MSG_NOTICE([Found $CCACHE, however this is not version
>> 3.1.4 or later. (it is: $CCACHE_VERSION_STRING). Ignoring.])
>>              AC_MSG_RESULT([no, disabling ccache])
>>              CCACHE=
>>          else
>>
>> I will verify, in our infrastructure, that machines that previously
>> were using ccache still do so ( after these changes ).
>>
>> -Chris.
>