RFR: JDK-8034193: Move X11 wrapper generator files to make/src and make/data
Erik Joelsson
erik.joelsson at oracle.com
Wed Feb 12 09:13:31 UTC 2014
Thanks for the feedback, here is a new webrev with the directory names
changed to "x11wrappergen".
http://cr.openjdk.java.net/~erikj/8034193/webrev.jdk.02/
I agree that it looks better.
/Erik
On 2014-02-11 17:58, Tim Bell wrote:
> On 02/11/14 06:09 AM, Magnus Ihse Bursie wrote:
>> On 2014-02-11 14:10, Erik Joelsson wrote:
>>> Another gensrc cleanup, this time it's X11 wrappers source locations.
>>>
>>> * Moving WrapperGenerator.java to jdk/make/src/classes/...
>>> * Moving the input data files to jdk/make/data/...
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8034193
>>> Webrev: http://cr.openjdk.java.net/~erikj/8034193/webrev.jdk.01/
>>
>> Looks great! Feel free to shorten x11wrappergenerator to
>> x11wrappergen; please just do so in make/data as well in that case.
>
> I agree. Other than that this looks good to me as well.
>
> Tim.
>
More information about the build-dev
mailing list