<AWT Dev> RFR: Allow using a system installed libpng
Omair Majid
omajid at redhat.com
Wed Feb 12 22:55:14 UTC 2014
Hi,
* Magnus Ihse Bursie <magnus.ihse.bursie at oracle.com> [2014-02-12 17:49]:
>
> On 2014-02-12 18:47, Andrew Hughes wrote:
> >>To be extremely clear: Andrew, do you object to bringing Omairs patch,
> >>as it is, into OpenJDK?
> >>
> >Yes.
>
> Okay then.
>
> I'll put a mental note to revisit libpng when cleaning up
> libraries.m4.
Assuming that I have the cycles to clean up some stuff, what's the
minimal I could get away with (to enable system libpng support)?
> Are we in agreement that it should to the following:
> --with-libpng=bundled | system | <some path>
> and if "system" is selected, it should first check with pkg-config,
> and only if that fails, try hard-coded values. In any case it should
> try to compile a short code to see that it works properly. (This is
> not needed for bundled; that is assumed to be working).
Would it be sufficient if I updated the patch to use PGK_CHECK_MODULES
and simply fail if that doesn't work? I will be happy to implement
something more complex if you can sketch it out.
Thanks,
Omair
--
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681
More information about the build-dev
mailing list