RFR: JDK-8034788 Rewrite toolchain.m4 to support multiple toolchains per platform

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Thu Feb 13 21:27:58 UTC 2014


On 2014-02-13 14:39, Magnus Ihse Bursie wrote:
> On 2014-02-13 13:20, Erik Joelsson wrote:
>>
>> ~230-300: Many rather long lines, consider breaking them up?
>
It turned out that it was not a good idea to line break AC_MSG_* 
functions. :-( I didn't verify that properly before; my bad.

Here's a new-new review which restores the old long (but 
properly-looking) AC_MSG lines.

(If you're curious, the line break was printed verbatim. Putting a 
trailing \ did remove the line break, but then the indentation level 
showed up as verbatim spaces in the output.)

WebRev: 
http://cr.openjdk.java.net/~ihse/JDK-8034788-rewrite-toolchain-m4/webrev.03

/Magnus




More information about the build-dev mailing list