RFR: JDK-8034199 Add 'reconfigure' target for re-creating a configuration

[Erik Joelsson]

On 2014-02-17 03:10, David Holmes wrote:
> On 12/02/2014 11:36 PM, Magnus Ihse Bursie wrote:
>> Sometimes we need to re-run configure, due to changes in configure
>> files. Make detects such changes and forces a new run of configure.
>>
>> If configure was run with a long command line, it's tricky to get this
>> right again. However, this can be done automatically by the Makefile.
>
> Presumably the right way to do this would be:
>
> "make clean reconfigure ..."
>
> otherwise you could get some kind of weird hybrid build. I'm not sure 
> that every change in spec.gmk, for example would force a recompile of 
> everything that depended on something in there. But perhaps it does?
>
That would be the safe way of doing it yes. If you know what you are 
doing, it's often safe to skip the clean however. We certainly do not 
have complete dependencies on everything in the spec file.
>> By adding a new target 'reconfigure', if we have an existing
>> configuration, configure will be ran again with the same arguments as
>> last time.
>
> Sometimes I've re-run configure with the exact same args and I get a 
> warning about doing this over an existing configuration ?? At which 
> point I either do a dist-clean or "rm -rf ...".
>
That's a standard warning that's always written when overwriting an 
existing configuration. If you know that you didn't change anything, you 
may ignore it, but to be safe, do a clean. I don't think dist-clean adds 
anything here, it just forces you do rerun configure yet again.

/Erik
> David
>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8034199
>> WebRev:
>> http://cr.openjdk.java.net/~ihse/JDK-8034199-add-reconfigure-target/webrev.01 
>>
>>
>>
>> /Magnus