8032443: ,Java Access Bridge version strings need to be fixed

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Wed Feb 19 09:55:14 UTC 2014


On 2014-02-18 05:22, Pete Brunet wrote:
> Please review this change:
> http://cr.openjdk.java.net/~ptbrunet/JDK-8032443/webrev.00/
>
> for this bug:
> https://bugs.openjdk.java.net/browse/JDK-8032443
>
> Some resource compiler defines are need so the JAB DLLs Properties sheet
> will have the proper information.  This change fixes the names that are
> displayed.

Pete,

Even though I don't know how these RC flags are interpreted, I notice 
that virtually all other libraries that has a JDK_FNAME and 
JDK_INTERNAL_NAME also has a JDK_FTYPE=0x2L.

(In fact, generalizing the pattern

     RC_FLAGS := $(RC_FLAGS) \
         -D "JDK_FNAME=FOO.dll" \
         -D "JDK_INTERNAL_NAME=FOO" \
         -D "JDK_FTYPE=0x2L",

that appear all over the place is something that has been on our agenda, 
unfortunately for far too long without happening).

It seems that there need to be a good reason for these libraries to not 
match this pattern.

/Magnus



More information about the build-dev mailing list