Fwd: Re: RFR(xxs): 8072935: Fix missing newline at end of file after 8067447
Erik Joelsson
erik.joelsson at oracle.com
Fri Feb 13 10:35:55 UTC 2015
If we are to create such a check, please also include .gmk, .properties,
.m4 and Makefile. In JDK-8072950 I'm adding a workaround for missing
line endings in properties files.
/Erik
On 2015-02-13 11:09, David Holmes wrote:
> On 13/02/2015 7:23 PM, Volker Simonis wrote:
>> Hi,
>>
>> could somebody please sponsor and push this change.
>
> Push it to where, as what? I thought you wanted a jcheck addition.
>
> David
>
>> Thanks,
>> Volker
>>
>>
>> On Fri, Feb 13, 2015 at 7:49 AM, Martin Buchholz
>> <martinrb at google.com> wrote:
>>> Source files should have exactly one trailing newline.
>>>
>>> find -iregex '.*\.\(java\|txt\|c\|cc\|h\|hpp\|cpp\)$' | xargs perl
>>> -0777 -ne
>>> 'print "Must have exactly one trailing newline: $ARGV\n" unless
>>> m~[^\n]\Z~s'
>>>
>>>
More information about the build-dev
mailing list