Fwd: Re: RFR(xxs): 8072935: Fix missing newline at end of file after 8067447

[Volker Simonis]

Hi Erik,

I've created "CODETOOLS-7901298: jcheck should check that every file
ends with exactly one newline"
(https://bugs.openjdk.java.net/browse/JDK-8072935) and submitted a fix
(http://cr.openjdk.java.net/~stuefe/webrevs/8072935/webrev.01/webrev/)
to the code-tools-dev at openjdk.java.net list for review.

Do you suggest to check .gmk, .properties, .m4 and Makefile ONLY for
missing new line at the end of file or also for the other white-space
errors like trailing whitespace, tabs (obviously wouldn't apply to
Makefiles) and \r? Currently these files aren’t checked at all. Maybe
we can discuss this on the code-tools-dev at openjdk.java.net thread?

Regards,
Volker


On Fri, Feb 13, 2015 at 11:35 AM, Erik Joelsson
<erik.joelsson at oracle.com> wrote:
> If we are to create such a check, please also include .gmk, .properties, .m4
> and Makefile. In JDK-8072950 I'm adding a workaround for missing line
> endings in properties files.
>
> /Erik
>
>
> On 2015-02-13 11:09, David Holmes wrote:
>>
>> On 13/02/2015 7:23 PM, Volker Simonis wrote:
>>>
>>> Hi,
>>>
>>> could somebody please sponsor and push this change.
>>
>>
>> Push it to where, as what? I thought you wanted a jcheck addition.
>>
>> David
>>
>>> Thanks,
>>> Volker
>>>
>>>
>>> On Fri, Feb 13, 2015 at 7:49 AM, Martin Buchholz <martinrb at google.com>
>>> wrote:
>>>>
>>>> Source files should have exactly one trailing newline.
>>>>
>>>> find -iregex '.*\.\(java\|txt\|c\|cc\|h\|hpp\|cpp\)$' | xargs perl -0777
>>>> -ne
>>>> 'print "Must have exactly one trailing newline: $ARGV\n" unless
>>>> m~[^\n]\Z~s'
>>>>
>>>>
>