[9] Review Request: 8039269 images/cursors should not be in ${java.home}/lib

Erik Joelsson erik.joelsson at oracle.com
Mon Feb 16 11:13:31 UTC 2015


Hello Sergey,

The build changes look ok to me.

It's unfortunate that you had to explicitly exclude the file from 
CompileProperties, but I don't see a better solution at this time. 
Ideally, I would like to see a different file name extension for 
properties files being compiled than to those being cleaned.

/Erik

On 2015-02-13 19:01, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for jdk 9.
> As requested cursor related properties/images were moved from /lib to the java.desktop.
>   - Image prefixes were removed because I moved them to the os specific location.
>   - Windows version of cursors.properties was removed, because it was mostly the same as shared version.
>   - ***NoDrop images were removed, because they are the same as invalid32x32.gif. cursors.properties was updated accordingly.
>   - Note that if in the future some osx/unix will demand some specific images/properties, it will be necessary to place them to the correct folder only.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8039269
> Webrevs can be found at:
>      http://cr.openjdk.java.net/~serb/8039269/webrev.00/root
>      http://cr.openjdk.java.net/~serb/8039269/webrev.00/jdk
>




More information about the build-dev mailing list