[9] Review Request: 8039269 images/cursors should not be in ${java.home}/lib

Sergey Bylokhov sergey.bylokhov at oracle.com
Mon Feb 16 11:57:14 UTC 2015


Hello,
Here is an updated version of the fix:

http://cr.openjdk.java.net/~serb/8039269/webrev.01

----- Alan.Bateman at oracle.com wrote:

> On 13/02/2015 18:01, Sergey Bylokhov wrote:
> > Hello.
> > Please review the fix for jdk 9.
> > As requested cursor related properties/images were moved from /lib
> to the java.desktop.
> >   - Image prefixes were removed because I moved them to the os
> specific location.
> >   - Windows version of cursors.properties was removed, because it
> was mostly the same as shared version.
> >   - ***NoDrop images were removed, because they are the same as
> invalid32x32.gif. cursors.properties was updated accordingly.
> >   - Note that if in the future some osx/unix will demand some
> specific images/properties, it will be necessary to place them to the
> correct folder only.
> >
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8039269
> > Webrevs can be found at:
> >      http://cr.openjdk.java.net/~serb/8039269/webrev.00/root
> >      http://cr.openjdk.java.net/~serb/8039269/webrev.00/jdk
> >
> As Mandy pointed, you use try-with-resources. Also I think you can use
> 
> "in" rather than "fis" as the input stream is no longer a
> FileInputStream.
> 
> I think the main thing here is that it has been established that 
> cursor.properties is not a supported interface, that was the question
> 
> that issue was trying to establish for a long time. Also good to have
> 
> these files moved out of the conf directory.
> 
> -Alan



More information about the build-dev mailing list