RFR (XS) 8031064: build_vm_def.sh not working correctly for new build cross compile

Dean Long dean.long at oracle.com
Fri Jan 16 10:47:27 UTC 2015


On 1/15/2015 2:57 PM, Magnus Ihse Bursie wrote:
> On 2015-01-15 08:01, David Holmes wrote:
>>
>> If the build-dev guys confirm we already assume bash that is fine.
>
> For the rest of the world, we only use bash. For hotspot, we will use 
> bash if called from the top-level Makefile. I can't say anything about 
> what the convention have been for calling the hotspot makefiles 
> directly, though.
>
> /Magnus

"sh" or "bash", it shouldn't matter.  Our makefiles are already using 
Bourne shell syntax,
so if someone tries to use "make SHELL=csh", it will fail almost 
immediately.  Therefore,
I think "NM=$(NM) sh ..." should be safe.

dl

https://www.gnu.org/software/make/manual/make.html#Choosing-the-Shell



More information about the build-dev mailing list