RFR (XS) 8031064: build_vm_def.sh not working correctly for new build cross compile

[Dave Pointon]

Hi all ,

IMO, we should be fine as long as we continue to restrict ourselves to the
use of Bourne syntax i.e. avoid wandering into the realms of the quirks
provided by bash, in both make recipes and the utility & tool scripts - I
say this only because shell shock affected  certain platforms such that
bash is not available on those platform(s) e.g. AIX.

Just my 10c FWIW ....

--
Dave Pointon FIAP MBCS -
​ Contractor engaged by IBM

​​

Now I saw, tho' too late, the folly of beginning a work before we count the
cost
and before we we judge rightly of our strength to go thro' with it -
Robinson Crusoe

On 16 January 2015 at 10:47, Dean Long <dean.long at oracle.com> wrote:

> On 1/15/2015 2:57 PM, Magnus Ihse Bursie wrote:
>
>> On 2015-01-15 08:01, David Holmes wrote:
>>
>>>
>>> If the build-dev guys confirm we already assume bash that is fine.
>>>
>>
>> For the rest of the world, we only use bash. For hotspot, we will use
>> bash if called from the top-level Makefile. I can't say anything about what
>> the convention have been for calling the hotspot makefiles directly, though.
>>
>> /Magnus
>>
>
> "sh" or "bash", it shouldn't matter.  Our makefiles are already using
> Bourne shell syntax,
> so if someone tries to use "make SHELL=csh", it will fail almost
> immediately.  Therefore,
> I think "NM=$(NM) sh ..." should be safe.
>
> dl
>
> https://www.gnu.org/software/make/manual/make.html#Choosing-the-Shell
>