RFR (XS) 8031064: build_vm_def.sh not working correctly for new build cross compile

Dmitry Samersoff dmitry.samersoff at oracle.com
Thu Jan 22 08:32:06 UTC 2015


Dean,

Looks good for me. (not a reviewer)

Thank you for fixing it.

-Dmitry

On 2015-01-22 01:39, Dean Long wrote:
> Thanks Dmitry.  The updated webrev is here:
> 
>     http://cr.openjdk.java.net/~dlong/8031064/webrev.3/
> 
> dl
> 
> On 1/21/2015 12:11 AM, Dmitry Samersoff wrote:
>> Dean,
>>
>> vm.make  ll. 247
>>
>> 1. *.o should be  $(Obj_Files)
>>
>> 2.
>>
>> $(NM) --defined-only *.o | sort -k3 -u |
>>   awk '/$(VMDEF_PAT)/{ print "\t" $$3 ";" }'
>>
>> should give you the same result with less efforts
>>
>> -Dmitry
>>
>> On 2015-01-21 07:59, Dean Long wrote:
>>> Here's version 2, which does everything in vm.make and doesn't do
>>> anything that is shell-specific:
>>>
>>> http://cr.openjdk.java.net/~dlong/8031064//webrev.2/
>>>
>>> thanks,
>>>
>>> dl
>>
> 


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.



More information about the build-dev mailing list