RFR (XS) 8031064: build_vm_def.sh not working correctly for new build cross compile

David Holmes david.holmes at oracle.com
Thu Jan 22 10:19:40 UTC 2015


On 22/01/2015 8:39 AM, Dean Long wrote:
> Thanks Dmitry.  The updated webrev is here:
>
>      http://cr.openjdk.java.net/~dlong/8031064/webrev.3/

This looks weird:

+ VMDEF_PAT  = ^_ZTV
+ VMDEF_PAT := ^gHotSpotVM|$(VMDEF_PAT)
+ VMDEF_PAT := ^UseSharedSpaces$$|$(VMDEF_PAT)
+ VMDEF_PAT := ^_ZN9Arguments17SharedArchivePathE$$|$(VMDEF_PAT)

but I can sort of see why you wanted to do it that way.

I assume you have verified the results are identical?

I would be good to see this applied uniformly across all platforms as 
well (except windows).

Thanks,
David

> dl
>
> On 1/21/2015 12:11 AM, Dmitry Samersoff wrote:
>> Dean,
>>
>> vm.make  ll. 247
>>
>> 1. *.o should be  $(Obj_Files)
>>
>> 2.
>>
>> $(NM) --defined-only *.o | sort -k3 -u |
>>   awk '/$(VMDEF_PAT)/{ print "\t" $$3 ";" }'
>>
>> should give you the same result with less efforts
>>
>> -Dmitry
>>
>> On 2015-01-21 07:59, Dean Long wrote:
>>> Here's version 2, which does everything in vm.make and doesn't do
>>> anything that is shell-specific:
>>>
>>> http://cr.openjdk.java.net/~dlong/8031064//webrev.2/
>>>
>>> thanks,
>>>
>>> dl
>>
>



More information about the build-dev mailing list