RFR: JDK-8072897: File sawindbg.dll has incorrect file version

Tim Bell tim.bell at oracle.com
Tue Mar 17 14:36:05 UTC 2015


Erik:

> Please review this minor fix for sawindbg.dll. It is currently not 
> having version info added (the RC stuff) which all other dlls have. 
> Here is a minimal fix that basically adds the same values as for 
> jvm.dll except for the filename (FNAME) field.
>
> (Nmake is confusing)
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8072897
> Webrev: http://cr.openjdk.java.net/~erikj/8072897/webrev.hotspot.01/

Looks good to me, although I am not a 'R'eviewer in hotspot territory...

Tim




More information about the build-dev mailing list