RFR: JDK-8072897: File sawindbg.dll has incorrect file version
David Holmes
david.holmes at oracle.com
Wed Mar 18 02:04:16 UTC 2015
On 18/03/2015 12:36 AM, Tim Bell wrote:
> Erik:
>
>> Please review this minor fix for sawindbg.dll. It is currently not
>> having version info added (the RC stuff) which all other dlls have.
>> Here is a minimal fix that basically adds the same values as for
>> jvm.dll except for the filename (FNAME) field.
>>
>> (Nmake is confusing)
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8072897
>> Webrev: http://cr.openjdk.java.net/~erikj/8072897/webrev.hotspot.01/
>
> Looks good to me, although I am not a 'R'eviewer in hotspot territory...
I am :) Looks okay to me too.
Don't forget to submit via jprt with "-testset hotspot"
Thanks,
David
> Tim
>
More information about the build-dev
mailing list